Reviewed: https://review.openstack.org/264342 Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=0354fe00db11984da3ce2ae4b4113a1043e6c86d Submitter: Jenkins Branch: master
commit 0354fe00db11984da3ce2ae4b4113a1043e6c86d Author: Navid Pustchi <npust...@gmail.com> Date: Wed Jan 6 20:31:28 2016 +0000 Delete checks for default domain delete Currently defualt can not be deleted through update API. There are checks in update_domain to prevent this. This change deletes all checks and related tests for deleting the default domain, including new default domain and old default domain tests. Change-Id: I31a9cd7ac8c394b38038343f85f405080ca5f915 Closes-Bug: 1522616 ** Changed in: keystone Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1522616 Title: It's possible to disable the default domain through domain update API Status in OpenStack Identity (keystone): Fix Released Bug description: We currently forbid the ability of deleting the default domain [0] (or at least make it really hard to do so). There is nothing in the update domain flow that protects against disabling the default domain. We should add the same check to prevent someone from accidentally disabling the default domain. Otherwise it just exposes the same behavior that we wanted to prevent in the first place. I was able to recreate this with these steps - http://cdn.pasteraw.com/38uku7bb83dt4prj6f66hc9ccuft0ew [0] https://github.com/openstack/keystone/blob/45c19fcd8c4cc382a7471432cd9f72b809e1d5b1/keystone/resource/core.py#L526-L532 To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1522616/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp