Reviewed: https://review.openstack.org/245898 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=61813e69f7b4300d5cc32d484720b4f45b8c10bc Submitter: Jenkins Branch: master
commit 61813e69f7b4300d5cc32d484720b4f45b8c10bc Author: Bob Ball <[email protected]> Date: Mon Nov 16 17:24:23 2015 +0000 XenAPI: Fix race in rotate_xen_guest_logs It's possible that a log file is created while this script is running, and if being created after we get the valid last_dom_ids then the log file may be deleted incorrectly. Also add some logging which can be used to trace any future race conditions Change-Id: I1df1a0775a7dae41105d6c41b046c86002eb5eec Closes-Bug: 1516721 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1516721 Title: XenAPI: Race condition in test_get_console_output_with_unlimited_size Status in OpenStack Compute (nova): Fix Released Bug description: A race condition was seen in the following CI runs in the last 24 hours: http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/64/245764/1/16088/index.html http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/40/245640/1/16051/index.html http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/73/242573/5/15990/index.html http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/86/216086/10/16086/index.html 2015-11-16 06:47:05.268 INFO nova.compute.manager [req-26581556-c231-47cc-9ea7-b977de8180f6 tempest-ServerActionsTestJSON-1889710210 tempest-ServerActionsTestJSON-1027908766] [instance: ff735fb8-cc77-4114-bc99-889a83b803fc] Took 13.52 seconds to build instance. ... 2015-11-16 06:47:06.502 23377 ERROR nova.virt.xenapi.vmops Failure: ['XENAPI_PLUGIN_FAILURE', 'get_console_log', 'IOError', "[Errno 2] No such file or directory: '/var/log/xen/guest/console.95'"] ... 2015-11-16 06:49:37.785 23377 ERROR nova.virt.xenapi.vmops Failure: ['XENAPI_PLUGIN_FAILURE', 'get_console_log', 'IOError', "[Errno 2] No such file or directory: '/var/log/xen/guest/console.95'"] If a domain is started while rotate_xen_guest_logs is running, it's possible that the log file will be created and then immediately deleted. Secondly, there is no logging of the rotate_xen_guest_logs script; so if this is not the expected race, further debugging is impossible. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1516721/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
