** Changed in: nova/kilo
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1494653
Title:
Remove unnecessary 'context' parameter from quotas reserve method call
Status in OpenStack Compute (nova):
Fix Released
Status in OpenStack Compute (nova) kilo series:
Fix Released
Bug description:
In patch [1] 'context' parameter was removed from quota-related remotable
method signatures.
In patch [2] use of 'context' parameter was removed from quota-related
remotable method calls.
Still there are some occurrances where 'context' parameter is passed
to quotas.reserve method which is leading to error "ValueError:
Circular reference detected".
For eg: while restarting nova-compute if there are any instance
whose vm_state is 'DELETED' but that instance is not marked as deleted in db.
In that case, while calling _init_instance method it raises below error.
2015-09-08 00:36:34.133 ERROR nova.compute.manager
[req-3222b8a4-0542-48cf-a2e1-c92e5fd91e5e None None] [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] Failed to complete a deletion
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] Traceback (most recent call last):
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/opt/stack/nova/nova/compute/manager.py", line 952, in _init_instance
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] self._complete_partial_deletion(context,
instance)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/opt/stack/nova/nova/compute/manager.py", line 879, in _complete_partial_d
eletion
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] bdms =
objects.BlockDeviceMappingList.get_by_instance_uuid(
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/local/lib/python2.7/dist-packages/oslo_versionedobjects/base.py", lin
e 197, in wrapper
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] ctxt, self, fn.__name__, args, kwargs)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/opt/stack/nova/nova/conductor/rpcapi.py", line 246, in object_action
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] objmethod=objmethod, args=args,
kwargs=kwargs)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/client.py", line
158, in call
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] retry=self.retry)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/local/lib/python2.7/dist-packages/oslo_messaging/transport.py", line 90,
in _send
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] timeout=timeout, retry=retry)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqpdriver.py",
line 431, in send
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] retry=retry)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqpdriver.py",
line 399, in _send
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] msg = rpc_common.serialize_msg(msg)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/common.py",
line 286, in serialize_msg
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] _MESSAGE_KEY: jsonutils.dumps(raw_msg)}
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/local/lib/python2.7/dist-packages/oslo_serialization/jsonutils.py", line
185, in dumps
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] return json.dumps(obj, default=default,
**kwargs)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/lib/python2.7/json/__init__.py", line 250, in dumps
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] sort_keys=sort_keys, **kw).encode(obj)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/lib/python2.7/json/encoder.py", line 207, in encode
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] chunks = self.iterencode(o,
_one_shot=True)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] File
"/usr/lib/python2.7/json/encoder.py", line 270, in iterencode
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] return _iterencode(o, 0)
2015-09-08 00:36:34.133 TRACE nova.compute.manager [instance:
00c7a9ae-bff1-461f-ab95-0e8f15327536] ValueError: Circular reference detected
[1] https://review.openstack.org/#/c/164268/
[2] https://review.openstack.org/#/c/160499/
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1494653/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
