Public bug reported: def enable_dhcp_helper(self, network_id): """Enable DHCP for a network that meets enabling criteria.""" network = self.safe_get_network_info(network_id) if network: self.configure_dhcp_for_network(network)
Its quite possible that we can get exceptions in configure_dhcp_for_network and its better to call its safer counterpart, which takes care of handling any exceptions. ** Affects: neutron Importance: Undecided Assignee: Sudhakar Gariganti (sudhakar-gariganti) Status: In Progress ** Tags: l3-ipam-dhcp ** Changed in: neutron Assignee: (unassigned) => Sudhakar Gariganti (sudhakar-gariganti) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1495628 Title: In DHCP agent's enable_dhcp_helper, its good to call safe_configure_dhcp_for_network Status in neutron: In Progress Bug description: def enable_dhcp_helper(self, network_id): """Enable DHCP for a network that meets enabling criteria.""" network = self.safe_get_network_info(network_id) if network: self.configure_dhcp_for_network(network) Its quite possible that we can get exceptions in configure_dhcp_for_network and its better to call its safer counterpart, which takes care of handling any exceptions. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1495628/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp