After another look, I think 2 occurrance make it ok to write a helper
function....
** Changed in: nova
Status: Confirmed => Invalid
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1438093
Title:
Redundant method _set_vm_state in conductor _live_migrate
Status in OpenStack Compute (nova):
Invalid
Bug description:
In this file:
https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L600
Implementing _set_vm_state() method in _live_migrate() method is unnecessary.
It could be used method from line #590:
def _set_vm_state_and_notify(self, context, instance_uuid, method, updates,
ex, request_spec):
scheduler_utils.set_vm_state_and_notify(
context, instance_uuid, 'compute_task',
method, updates,ex, request_spec, self.db)
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1438093/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
