I'll try to avoid exaggeration here. My commit [1] was about a Shop / utils function, maybe not exactly a bottom layer of yade (at least, not in my opinion).
As illustrated by the present bug and the launchpad question, [1] could be problematic in case of Python code (hardcoded in trunk or in users scripts) involving some other functions exposed through boost python with a specific type of arguments. It is true I did not foresee this problem in [1], in spite of the discussion [2] (see also therein for the motivations to commit [1]) As for #4 and Robert's list #1, I went through it and do not think there is now (was ?) any problem in this list due to commit [1], and in possible connection with the present bug. I will look closely into py/pack/_packPredicates. [1] https://github.com/yade/trunk/commit/1db13fb1183b9e294dc9761da76cfa4fc2791cc1 [2] https://www.mail-archive.com/[email protected]/msg13339.html, fourth item in particular... -- You received this bug notification because you are a member of Yade developers, which is subscribed to Yade. https://bugs.launchpad.net/bugs/1804621 Title: bodyNumInteractionsHistogram broken Status in Yade: New Bug description: See https://answers.launchpad.net/yade/+question/676284 and: ##################### O.bodies.append(sphere((0,0,0),1,dynamic=False)) O.bodies.append(sphere((0,0,1.9),1,dynamic=False)) O.step() print 'BodyNumInteractions Histogram', bodyNumInteractionsHistogram(aabbExtrema()) #################### which returns (with trunk version) : ArgumentError: Python argument types in yade._utils.bodyNumInteractionsHistogram(list) did not match C++ signature: bodyNumInteractionsHistogram(boost::python::tuple aabb, bool contactOnly=False) because my commit [*] changed the Python return type of aabbExtrema() from tuple to list. Possible (and easiest) fix would be to change all corresponding py::tuple aabb from py::list aabb. Agree ? Or do we want this function to deal with Python tuples and not lists ?.. Jérôme [*] https://github.com/yade/trunk/commit/1db13fb1183b9e294dc9761da76cfa4fc2791cc1 To manage notifications about this bug go to: https://bugs.launchpad.net/yade/+bug/1804621/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
