On 05/27/2016 05:22 AM, [email protected] wrote:
------------------------------------------------------------
revno: 3874
committer: jduriez <[email protected]>


=== modified file 'pkg/dem/Shop_02.cpp'
+               if( !dynamic_cast<Sphere*>(Body::byId(I->getId1(),scene)->shape.get()) || 
!dynamic_cast<Sphere*>(Body::byId(I->getId2(),scene)->shape.get()) ) continue; // test intended to +          if( 
!dynamic_cast<Sphere*>(Body::byId(I->getId1(),scene)->shape.get()) || 
!dynamic_cast<Sphere*>(Body::byId(I->getId2(),scene)->shape.get()) ) continue; // test intended to disregard 
boundary interactions (in non-periodic simulations)

Hi Jérôme,
A problem I see is you made of fabricTensor() something which will work only for spheres while it was working perfectly for every possible shape before the above change. I don't understand the relation between the "split" parameter and this change.
Could you please explain?

Besides, small tips on coding: better use getClassIndex() to check types, not plain cast<>'s (I know casts still appear here and there but we should certainly not introduce more of them).

Cheers.

Bruno


_______________________________________________
Mailing list: https://launchpad.net/~yade-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to