Entering now general discussion, do you mean each commit should be discussed on yade-dev ? In this case I added a one-line function that returns a variable and does not touch anything. I considered it as completely harmless and possibly useful for everyone, hence I commited.
Up to now I considered that thanks to git, the buildboot (when it works), etc.., we can enjoy a collaborative work on a (open source) code that belongs to everyone, without too much control. Errors, still possible, are spotted and corrected thanks to feedback of other devs, or users, when errors appear (which, finally, does not happen so often it seems). If we have to adopt a centralized workflow, I would conform the decision whatever my thoughts. But this should come from a global consensus, not from a discussion between 2 people, I think. ________________________________ From: Yade-dev [[email protected]] on behalf of Bruno Chareyre [[email protected]] Sent: December 3, 2014 1:55 PM To: [email protected] Subject: Re: [Yade-dev] [Branch ~yade-pkg/yade/git-trunk] Rev 3550: Add of O.thisScene() function to know in which scene we are Jérôme, I think the commit is right but I have the same comment as before: please don't touch this kind of code without a note here on yade-dev. Of course you can change whatever you like in your local copy, so my request should not block your production at any point. Pushing to trunk is another thing. I can't track changes if people start changing low level code silently just like that. Thanks Bruno On 01/12/14 20:49, [email protected]<mailto:[email protected]> wrote: ------------------------------------------------------------ revno: 3550 committer: jduriez <[email protected]><mailto:[email protected]> timestamp: Mon 2014-12-01 11:20:51 -0700 message: Add of O.thisScene() function to know in which scene we are modified: py/wrapper/yadeWrapper.cpp -- lp:yade https://code.launchpad.net/~yade-pkg/yade/git-trunk Your team Yade developers is subscribed to branch lp:yade. To unsubscribe from this branch go to https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected]<mailto:[email protected]> Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp -- _______________ Bruno Chareyre Associate Professor ENSE³ - Grenoble INP Lab. 3SR BP 53 38041 Grenoble cedex 9 Tél : +33 4 56 52 86 21 Fax : +33 4 76 82 70 43 ________________
_______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
