On 21 Jul 2017, at 10:18, Hussein Shafie wrote:
On 07/21/2017 09:30 AM, Leif Halvard Silli wrote:

    1) Changed message from:

    "Always save these characters as entity references:"

    to:

"In addition to characters outside the encoding, save the following
    characters as entity references:"

    2) The text area containing the user-specified characters is now
grayed out when checkbox "Save characters outside encoding as entity
    references" is unchecked.

The first change is of course perfect. :-) The second change, I am not
certain that I spot the difference compared with today - as it even
today is grayed out in that situation. Did you mean that you made it
grayer, e.g. by making the background grayer?


On some Java platforms (Linux, Windows but not the Mac?), unlike what happens for single-line text fields, a "disabled"/non-editable multi-line text area is not automatically given a light-gray background.

Yes: Not on Mac. On (my) Mac it was already grayed out/disabled.

The way I see it, the error is to gray out that area at all.

Yes, I certainly understand your point. However we have NOT implemented your RFEs. We just made what already exists a bit more explicit.

OK. Then: While trying to stay very close to the current wording yet improving them to help users, please consider the following twikings:

   Current first text phrase:
* Save characters outside encoding as entity references
   Suggested alternative twikings:
* Save outside the encoding character references as entity references
* Save character references outside encoding as entity references
* Save character references for outside the encoding characters as entity references

   Current second text phrase:
* In addition to characters outside the encoding, save the following characters as entity references:
   Suggested alternative twikings:
* In addition to outside the encoding character references, save these characters as entity references: * In addition to character references outside the encoding, save these characters as entity references: * [alternatively:], save the following characters as entity references:

My justification for these twikes is that they achieve the following two points:

* FIRSTLY, they make clear that, really, it is character references that are saved as entity references. This, IMO, reflects what XXE actually does internally. For instance, with the 'save as entity reference' feature enabled, if you try to manually insert such a character as a numeric character reference, XXE will convert/save that numeric character reference to the corresponding entity reference.) * SECONDLY, (and more importantly) they remind/highlight/hint to users that character references are used whenever entity references are not used. (”Character reference” is XML 1.0 terminology for ”numeric character references”, see https://www.w3.org/TR/REC-xml/#dt-charref)
--
leif halvard silli

--
XMLmind XML Editor Support List
xmleditor-support@xmlmind.com
http://www.xmlmind.com/mailman/listinfo/xmleditor-support

Reply via email to