Nikolai Weibull schrieb am 24.12.18 um 12:00: > Stefan Behnel, 2018-12-24 11:43: >> Nick Wellnhofer schrieb am 19.12.18 um 17:02: >>> On 30/11/2018 11:41, Nikolai Weibull via xml wrote: >>>> OK, now I understand why it was working in my copy of the repository and >>>> not yours. Something went wrong when you applied the patch, Daniel, as a >>>> line was elided. Here’s a fix. We want to include XML_RELAXNG_TEXT here >>>> as well, otherwise it won’t work. The second part of the patch below was >>>> just to reorder the types to be listed in alphabetical order, so you may >>>> certainly skip that. >>> >>> Stefan, can you confirm that Nikolai's patch fixes the lxml issue? >> >> Sorry for the silence, I wasn't aware that I had to do something. Problem >> is, the patch that Nikolai sent doesn't apply for me. > >> Nikolai, could you create a patch against the latest master that makes >> relaxng.c the way you think it should be? (Or should have been in the first >> place?) Please attach it rather than pasting it into a mail, to make sure >> it passes without whitespace issues. > > I just applied the patch (with patch < a.patch) without issue against > master. I’m attaching it as well so that you can try that.
With that patch applied, all tests in lxml pass again, and the stipped-down test case as well. I also double-checked it by unapplying the patch, things are still failing with the master branch and it's really just this change that makes them work again. Thanks, Nikolai! Stefan _______________________________________________ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
