2016-05-27 1:59 GMT-06:00 Shlomi Fish <shlo...@shlomifish.org>:
> thanks for your patch, but shouldn't a regression test be added to the code 
> (to
> protect against future breakages?)

That would be a good idea, but I have never been able to run the tests
successfully, so I am not sure how to add a new one. I use Arch Linux,
and I'm attaching the output of `make check`. If you can explain to me
how to fix this problem, I may be able to add a test. Otherwise,
please feel free to add a test to my patch and resubmit it.

-Alex
make  all-recursive
make[1]: Entering directory '/home/alex/workspace/libxml2'
Making all in include
make[2]: Entering directory '/home/alex/workspace/libxml2/include'
Making all in libxml
make[3]: Entering directory '/home/alex/workspace/libxml2/include/libxml'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/include/libxml'
make[3]: Entering directory '/home/alex/workspace/libxml2/include'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/include'
make[2]: Leaving directory '/home/alex/workspace/libxml2/include'
Making all in .
make[2]: Entering directory '/home/alex/workspace/libxml2'
make[2]: Leaving directory '/home/alex/workspace/libxml2'
Making all in doc
make[2]: Entering directory '/home/alex/workspace/libxml2/doc'
Making all in .
make[3]: Entering directory '/home/alex/workspace/libxml2/doc'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/doc'
Making all in devhelp
make[3]: Entering directory '/home/alex/workspace/libxml2/doc/devhelp'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/doc/devhelp'
Making all in examples
make[3]: Entering directory '/home/alex/workspace/libxml2/doc/examples'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/doc/examples'
make[2]: Leaving directory '/home/alex/workspace/libxml2/doc'
Making all in example
make[2]: Entering directory '/home/alex/workspace/libxml2/example'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/alex/workspace/libxml2/example'
Making all in xstc
make[2]: Entering directory '/home/alex/workspace/libxml2/xstc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/alex/workspace/libxml2/xstc'
Making all in python
make[2]: Entering directory '/home/alex/workspace/libxml2/python'
make  all-recursive
make[3]: Entering directory '/home/alex/workspace/libxml2/python'
Making all in .
make[4]: Entering directory '/home/alex/workspace/libxml2/python'
make[4]: Nothing to be done for 'all-am'.
make[4]: Leaving directory '/home/alex/workspace/libxml2/python'
Making all in tests
make[4]: Entering directory '/home/alex/workspace/libxml2/python/tests'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/home/alex/workspace/libxml2/python/tests'
make[3]: Leaving directory '/home/alex/workspace/libxml2/python'
make[2]: Leaving directory '/home/alex/workspace/libxml2/python'
make[1]: Leaving directory '/home/alex/workspace/libxml2'
[ -d test   ] || ln -s ./test   .
[ -d result ] || ln -s ./result .
./runtest &&  ./testrecurse && ./testapi &&  ./testchar&&  ./testdict &&  
./runxmlconf
## XML regression tests
## XML regression tests on memory
## XML entity subst regression tests
## XML Namespaces regression tests
## Error cases regression tests
## Error cases stream regression tests
## Reader regression tests
## Reader entities substitution regression tests
## Reader on memory regression tests
## Walker regression tests
## SAX1 callbacks regression tests
## SAX2 callbacks regression tests
## XML push regression tests
## HTML regression tests
## Push HTML regression tests
## HTML SAX regression tests
## Valid documents regression tests
## Validity checking regression tests
## Streaming validity checking regression tests
## Streaming validity error checking regression tests
## General documents valid regression tests
## XInclude regression tests
## XInclude xmlReader regression tests
## XInclude regression tests stripping include nodes
## XInclude xmlReader regression tests stripping include nodes
## XPath expressions regression tests
## XPath document queries regression tests
## XPointer document queries regression tests
## xml:id regression tests
## URI parsing tests
## URI base composition tests
## Path URI conversion tests
## Schemas regression tests
## Relax-NG regression tests
## Relax-NG streaming regression tests
## Pattern regression tests
## C14N with comments regression tests
## C14N without comments regression tests
## C14N exclusive without comments regression tests
## C14N 1.1 without comments regression tests
## Catalog and Threads regression tests
Total 2976 tests, no errors
.........
## Parsing recursive test cases
## Parsing non-recursive test cases
## Parsing non-recursive huge case
Total 9 tests, no errors
Testing HTMLparser : 32 of 38 functions ...
Testing HTMLtree : 18 of 18 functions ...
Testing SAX2 : 38 of 38 functions ...
Testing c14n : 3 of 4 functions ...
Testing catalog : 27 of 36 functions ...
Testing chvalid : 9 of 9 functions ...
Testing debugXML : 25 of 28 functions ...
Testing dict : 10 of 13 functions ...
Testing encoding : 16 of 19 functions ...
Testing entities : 13 of 17 functions ...
Testing hash : 16 of 24 functions ...
Testing list : 19 of 26 functions ...
Testing nanoftp : 14 of 22 functions ...
Testing nanohttp : 13 of 17 functions ...
Testing parser : 61 of 70 functions ...
Testing parserInternals : 33 of 90 functions ...
Testing pattern : 10 of 15 functions ...
Testing relaxng : 14 of 24 functions ...
Testing schemasInternals : 0 of 2 functions ...
Testing schematron : 1 of 10 functions ...
Testing tree : 142 of 164 functions ...
Testing uri : 10 of 15 functions ...
Testing valid : 50 of 70 functions ...
Testing xinclude : 8 of 10 functions ...
Testing xmlIO : 40 of 50 functions ...
Testing xmlautomata : 3 of 19 functions ...
Testing xmlerror : 7 of 15 functions ...
Testing xmlmodule : 2 of 4 functions ...
Testing xmlreader : 76 of 86 functions ...
Testing xmlregexp : 16 of 30 functions ...
Testing xmlsave : 4 of 10 functions ...
Testing xmlschemas : 16 of 27 functions ...
Testing xmlschemastypes : 26 of 34 functions ...
Testing xmlstring : 26 of 30 functions ...
Testing xmlunicode : 166 of 166 functions ...
Testing xmlwriter : 52 of 80 functions ...
Testing xpath : 32 of 40 functions ...
Testing xpathInternals : 106 of 117 functions ...
Testing xpointer : 17 of 21 functions ...
Total: 1171 functions, 291083 tests, 0 errors
testing char range: 1 2 3 4 done
testing 1 byte char in document: 1 2 3 4 done
testing 2 byte char in document: 1 2 3 4 done
dictionary tests succeeded 20000 strings
Test suite: XML 1.0 (2nd edition) W3C Conformance Test Suite, 6 October 2000
Test cases: James Clark  XML 1.0 Tests
Test cases: Fuji Xerox Japanese Text Tests XML 1.0 Tests
Test cases: Sun Microsystems XML Tests
Test cases: 159 tests
Test cases: OASIS/NIST XML 1.0 Tests
Test cases: IBM XML 1.0 Tests
Test cases: IBM XML 1.1 Tests
Test cases: Richard Tobin's XML 1.0 2nd edition errata test suite 21 Jul 2003
Test cases: 34 tests
Test cases: Richard Tobin's XML 1.1 test suite 13 Feb 2003
Test cases: 57 tests
Test cases: Richard Tobin's XML Namespaces 1.0 test suite 14 Feb 2003
Test cases: 48 tests
Test cases: Richard Tobin's XML Namespaces 1.1 test suite 14 Feb 2003
Test cases: 8 tests
Test cases: Richard Tobin's XML 1.0 3rd edition errata test suite 1 June 2006
Test cases: 13 tests
Test cases: University of Edinburgh tests for XML 1.0 5th edition
Test cases: 393 tests
Test cases: Richard Tobin's XML Namespaces 1.0/1.1 2nd edition test suite 1 
June 2006
Test cases: 3 tests
Test cases: Bjoern Hoehrmann via HST 2013-09-18
Test cases: 9 tests
Ran 2273 tests, 15 errors, 0 leaks
Total 2273 tests, 15 errors, 0 leaks
See runxmlconf.log for detailed output
15 errors were expected
make[1]: Entering directory '/home/alex/workspace/libxml2/python'
make  all-recursive
make[2]: Entering directory '/home/alex/workspace/libxml2/python'
Making all in .
make[3]: Entering directory '/home/alex/workspace/libxml2/python'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/python'
Making all in tests
make[3]: Entering directory '/home/alex/workspace/libxml2/python/tests'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/python/tests'
make[2]: Leaving directory '/home/alex/workspace/libxml2/python'
cd tests && make tests
make[2]: Entering directory '/home/alex/workspace/libxml2/python/tests'
## running Python regression tests
TypeError: 'NoneType' object is not callable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./tstLastError.py", line 80, in <module>
    test.test1()
  File "./tstLastError.py", line 62, in test1
    line=0)
  File "./tstLastError.py", line 30, in failUnlessXmlError
    f(*args)
  File "/home/alex/workspace/libxml2/python/libxml2.py", line 1374, in readFile
    ret = libxml2mod.xmlReadFile(filename, encoding, options)
SystemError: <built-in function xmlReadFile> returned a result with an error set
-- tstLastError.py

make[2]: Leaving directory '/home/alex/workspace/libxml2/python/tests'
make[1]: Leaving directory '/home/alex/workspace/libxml2/python'
make  check-recursive
make[1]: Entering directory '/home/alex/workspace/libxml2'
Making check in include
make[2]: Entering directory '/home/alex/workspace/libxml2/include'
Making check in libxml
make[3]: Entering directory '/home/alex/workspace/libxml2/include/libxml'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/include/libxml'
make[3]: Entering directory '/home/alex/workspace/libxml2/include'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/include'
make[2]: Leaving directory '/home/alex/workspace/libxml2/include'
Making check in .
make[2]: Entering directory '/home/alex/workspace/libxml2'
make[2]: Leaving directory '/home/alex/workspace/libxml2'
Making check in doc
make[2]: Entering directory '/home/alex/workspace/libxml2/doc'
Making check in .
make[3]: Entering directory '/home/alex/workspace/libxml2/doc'
make[3]: Nothing to be done for 'check-am'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/doc'
Making check in devhelp
make[3]: Entering directory '/home/alex/workspace/libxml2/doc/devhelp'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/doc/devhelp'
Making check in examples
make[3]: Entering directory '/home/alex/workspace/libxml2/doc/examples'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory '/home/alex/workspace/libxml2/doc/examples'
make[2]: Leaving directory '/home/alex/workspace/libxml2/doc'
Making check in example
make[2]: Entering directory '/home/alex/workspace/libxml2/example'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/home/alex/workspace/libxml2/example'
Making check in xstc
make[2]: Entering directory '/home/alex/workspace/libxml2/xstc'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/home/alex/workspace/libxml2/xstc'
Making check in python
make[2]: Entering directory '/home/alex/workspace/libxml2/python'
make  check-recursive
make[3]: Entering directory '/home/alex/workspace/libxml2/python'
Making check in .
make[4]: Entering directory '/home/alex/workspace/libxml2/python'
make[4]: Nothing to be done for 'check-am'.
make[4]: Leaving directory '/home/alex/workspace/libxml2/python'
Making check in tests
make[4]: Entering directory '/home/alex/workspace/libxml2/python/tests'
make[4]: Nothing to be done for 'check'.
make[4]: Leaving directory '/home/alex/workspace/libxml2/python/tests'
make[3]: Leaving directory '/home/alex/workspace/libxml2/python'
make[2]: Leaving directory '/home/alex/workspace/libxml2/python'
make[1]: Leaving directory '/home/alex/workspace/libxml2'
_______________________________________________
xml mailing list, project page  http://xmlsoft.org/
xml@gnome.org
https://mail.gnome.org/mailman/listinfo/xml

Reply via email to