Daniel Veillard wrote: > I think the majority of those got applied, I fetched your commits:
I can see them at https://git.gnome.org/browse/libxml2 The repository at https://github.com/monnerat/libxml2 is a clone of upstream git://git.gnome.org/libxml2 with master untouched and an additional os400 branch with 14 commits introducing all the os400 stuff. > Applying: For OS/400 we can't use NULL comparison for iconv_t > Applying: Adds the os400 directory to dist for tarballs thinkpad:~/XML -> Obviously, you started from the big patch I sent you last year (there is no published branch for it on git.gnome.org). If you forget this local branch and use the github one, it should be ok with all your remark. The big patch has been split into several smaller commits. In addition, some bugs/additions have been applied since then. > only those 2 remaining patches seems to not have been commited then, the second one is a no brainer, on the other hand why use -1 for the cast to (iconv_t) when would could use 0 (as NULL) was used previously, any reason to not use > (iconv_t) 0 > instead of > (iconv_t) -1 > that would be way closer to the original, and less likely to raise an unwanted ABI issue. In the github branch, os400 sticks with your iconv_t use. Starting in a github.com/monnerat/libxml2 fresh clone (os400 branch), you should get: $ git rebase master First, rewinding head to replay your work on top of it... Applying: OS400: create architecture directory. Implement dlfcn emulation. Applying: doc/news.html: small update to avoid line join while generating NEWS. Applying: OS400: iconv functions compatibility wrappers and table builder. Applying: OS400: Easy character transcoding support Applying: OS400: UTF8<-->EBCDIC wrappers for system and external library calls Applying: OS400: implement some macros as functions for ILE/RPG language support (that as no macros). Applying: OS400: ILE RPG language header files. Applying: OS400: Add compilation scripts. Applying: OS400: Add README: compilation directives and OS/400 specific stuff. Applying: OS400: include in distribution tarball. Applying: OS400: implement XPath macros as procedures for ILE/RPG support. Applying: OS400: use C macros to implement equivalent RPG support procedures. Applying: OS400: Add some more C macros equivalent procedures. Applying: os400: make-src.sh: create physical file with target CCSID Sorry for misunderstanding. Cheers, Patrick _______________________________________________ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
