> On May 24, 2021, at 9:36 PM, Nick Rosbrook <rosbro...@gmail.com> wrote: > > There are several locations where the return code from calling into C is > negated when being converted to Error. This results in error strings > like "libxl error: <x>", rather than the correct message. Fix all > occurrances of this by running: > > gofmt -w -r 'Error(-ret) -> Error(ret)' xenlight.go > > from tools/golang/xenlight. > > Signed-off-by: Nick Rosbrook <rosbro...@ainfosec.com>
Erk. I’d be tempted to say something more like: "Commit 871e51d2d4 changed the sign on the xenlight error types (making the values negative, same as the C-generated constants), but failed to remove the code changing the sign before casting to Error(). This results in…” I can edit this on check-in if you’re OK with it. Either way: Acked-by: George Dunlap <george.dun...@citrix.com>
