On 16.06.2021 12:43, Juergen Gross wrote: > On 16.06.21 11:56, Jan Beulich wrote: >> On 16.06.2021 09:30, Juergen Gross wrote: >>> --- a/arch/x86/xen/p2m.c >>> +++ b/arch/x86/xen/p2m.c >>> @@ -95,8 +95,8 @@ unsigned long *xen_p2m_addr __read_mostly; >>> EXPORT_SYMBOL_GPL(xen_p2m_addr); >>> unsigned long xen_p2m_size __read_mostly; >>> EXPORT_SYMBOL_GPL(xen_p2m_size); >>> -unsigned long xen_max_p2m_pfn __read_mostly; >>> -EXPORT_SYMBOL_GPL(xen_max_p2m_pfn); >>> +unsigned long xen_p2m_max_size __read_mostly; >>> +EXPORT_SYMBOL_GPL(xen_p2m_max_size); >> >> Instead of renaming the exported variable (which will break consumers >> anyway), how about dropping the apparently unneeded export at this >> occasion? > > Why do you think it isn't needed? It is being referenced via the inline > function __pfn_to_mfn() in arch/x86/include/asm/xen/page.h. And > __pfn_to_mfn() is used via lots of other inline functions and macros.
Oh, sorry. Not working that much with the Linux sources anymore, I didn't pay attention to include/ changes living ahead of *.c ones, and inferred from the last file touched being *.c that no headers were getting changed by the patch. Jan
