On 14/06/2021 15:54, Julien Grall wrote:
Hi Jan,
On 14/06/2021 15:52, Jan Beulich wrote:
This confuses disassemblers, at the very least. Move
.altinstr_replacement to .init.text. The previously redundant ALIGN()
now gets converted to page alignment, such that the hypervisor mapping
won't have this as executable (it'll instead get mapped r/w, which I'm
told is intended to be adjusted at some point).
Note that for the actual patching logic's purposes this part of
.init.text _has_ to live after _einittext (or before _sinittext), or
else branch_insn_requires_update() would produce wrong results.
Also, to have .altinstr_replacement have consistent attributes in the
object files, add "x" to the one instance where it was missing.
Signed-off-by: Jan Beulich <[email protected]>
Acked-by: Julien Grall <[email protected]>
Comitted.
Cheers,
--
Julien Grall
