Hi Jan > -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: Tuesday, May 18, 2021 3:28 PM > To: Penny Zheng <penny.zh...@arm.com> > Cc: Bertrand Marquis <bertrand.marq...@arm.com>; Wei Chen > <wei.c...@arm.com>; nd <n...@arm.com>; xen-devel@lists.xenproject.org; > sstabell...@kernel.org; jul...@xen.org > Subject: Re: [PATCH 06/10] xen: replace order with nr_pfns in assign_pages > for better compatibility > > On 18.05.2021 07:21, Penny Zheng wrote: > > Function parameter order in assign_pages is always used as 1ul << > > order, referring to 2@order pages. > > > > Now, for better compatibility with new static memory, order shall be > > replaced with nr_pfns pointing to page count with no constraint, like > > 250MB. > > While I'm not entirely opposed, I'm also not convinced. The new user could > as well break up the range into suitable power-of-2 chunks. In no case do I > view the wording "compatibility" here as appropriate. There's no > incompatibility at present. >
Yes, maybe the incompatibility is not the good choice here. Sure, the new user definitely could choose the workaround to break up the range, while it may cost extra time. And while considering MPU system, memory range size is often not in the power-of-2. > Jan Thanks Penny
