On 18.05.2021 05:58, Connor Davis wrote: > > On 5/17/21 5:22 AM, Jan Beulich wrote: >> On 14.05.2021 20:53, Connor Davis wrote: >>> Move struct grant_table; in grant_table.h above >>> ifdef CONFIG_GRANT_TABLE. This fixes the following: >>> >>> /build/xen/include/xen/grant_table.h:84:50: error: 'struct grant_table' >>> declared inside parameter list will not be visible outside of this >>> definition or declaration [-Werror] >>> 84 | static inline int mem_sharing_gref_to_gfn(struct grant_table *gt, >>> | >> There must be more to this, as e.g. the PV shim does get built with >> !GRANT_TABLE. Nevertheless, ... >> > Can you elaborate? I tested all defconfigs with and without grant tables > > enabled on x86 and ARM and they all build fine.
I'm confused: Everything building fine supports my statement, so if more elaboration was needed, it would be you to make more precise the conditions upon which a build failure would occur. But this is largely moot now, since I did commit your change yesterday already, for, as said, the potential of breaking the build being obvious enough. Jan
