Hi Juergen,
On 14/05/2021 10:42, Juergen Gross wrote:
On 14.05.21 11:35, Julien Grall wrote:
-struct connection *new_connection(connwritefn_t *write, connreadfn_t
*read);
+struct connection *new_connection(struct interface_funcs *funcs);
struct connection *get_connection_by_id(unsigned int conn_id);
void check_store(void);
void corrupt(struct connection *conn, const char *fmt, ...);
@@ -254,9 +258,6 @@ void finish_daemonize(void);
/* Open a pipe for signal handling */
void init_pipe(int reopen_log_pipe[2]);
-int writefd(struct connection *conn, const void *data, unsigned int
len);
-int readfd(struct connection *conn, void *data, unsigned int len);
-
extern struct interface_funcs socket_funcs;
Hmmm... I guess this change splipped in the staging before hand?
No, I just forgot to make the functions static.
Hmmm... I am not sure how this is related to my question. What I meant
it the line "extern struct interface_funcs ..." doesn't have a '+' in front.
If you look at the history, this was added by mistake in:
commit 2ea411bc2c0a5a4c7ab145270f1949630460e72b
Author: Juergen Gross <jgr...@suse.com>
Date: Wed Jan 13 14:00:20 2021 +0100
tools/xenstore: add read connection state for live update
Add the needed functions for reading connection state for live update.
As the connection is identified by a unique connection id in the state
records we need to add this to struct connection. Add a new function
to return the connection based on a connection id.
Signed-off-by: Juergen Gross <jgr...@suse.com>
Reviewed-by: Julien Grall <jgr...@amazon.com>
Acked-by: Wei Liu <w...@xen.org>
Juergen
--
Julien Grall
