On 04/05/2021 14:50, Olaf Hering wrote: > --log does not take a file, it specifies what is supposed to be logged. > > Signed-off-by: Olaf Hering <o...@aepfle.de>
Acked-by: Andrew Cooper <andrew.coop...@citrix.com>. That said, ... > --- > tools/hotplug/FreeBSD/rc.d/xencommons.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in > b/tools/hotplug/FreeBSD/rc.d/xencommons.in > index ccd5a9b055..36dd717944 100644 > --- a/tools/hotplug/FreeBSD/rc.d/xencommons.in > +++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in > @@ -23,7 +23,7 @@ required_files="/dev/xen/xenstored" > > XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid" > XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid" > -#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log" > +#XENCONSOLED_TRACE="none|guest|hv|all" > #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log" It would probably be clearer to untangle these in one go, leaving the result looking like: XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid" #XENCONSOLED_TRACE="none|guest|hv|all" XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid" #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log" I'd also be tempted to fold this and the NetBSD change together. It's not as if these bugfixes are distro-specific. It looks like a bug in NetBSD in c/s 2e8644e1d90, which was copied into FreeBSD by c/s 5dcdb2bf569. (P.S. Sorry Roger - both your bugs, starting from a decade ago). It really is idiotic that we've got a commonly named *_TRACE variable with totally different semantics for the two daemons. Then again, its far too late to fix this :( ~Andrew
