On Mon, Apr 12, 2021 at 04:13:19PM +0200, Jan Beulich wrote: > With the hooks no longer needing setting, p2m_pt_init() degenerates to > (about) nothing when !HVM. As a result, p2m-pt.c doesn't need building > anymore in this case, as long as p2m_pt_init() has proper surrogates put > in place. > > Unfortunately this means some new #ifdef-ary in p2m.c, but the mid-term > plan there is to get rid of (almost) all of it by splitting out the then > hopefully very few remaining non-HVM pieces. > > While the movement of the paging_mode_translate() check from > p2m_remove_page() to guest_physmap_remove_page() may not be strictly > necessary anymore (it was in an early version of this change), it looks > more logical to live in the latter function, allowing to avoid acquiring > the lock in the PV case. All other callers of p2m_remove_page() already > have such a check anyway (in the altp2m case up the call stack). > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
Acked-by: Roger Pau Monné <roger....@citrix.com> Thanks, Roger.
