On Tue, Apr 13, 2021 at 04:01:39PM +0200, Roger Pau Monne wrote: > diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c > index cadc8b2a05e..6be2d773d1d 100644 > --- a/tools/libs/light/libxl_cpuid.c > +++ b/tools/libs/light/libxl_cpuid.c > @@ -419,6 +419,136 @@ int > libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid, > return 0; > } > > +static int apply_cpuid(libxl_ctx *ctx, xc_cpu_policy_t policy,
I'm pretty sure we want `libxl__gc` here instead of `ctx`. `ctx` will then by available via `CTX`. (and the GC_* macro will not need to be called) Beside that, there is also the need to store libxc return values in 'r' instead 'rc', and maybe use LOG*D macros to log the domid on error messages. Thanks, -- Anthony PERARD
