On Thu, Apr 15, 2021 at 11:34:55AM +0200, Jan Beulich wrote: > On x86, idle and other system domains are implicitly PV. While I > couldn't spot any cases where this is actively a problem, some cases > required quite close inspection to be certain there couldn't e.g. be > some ASSERT_UNREACHABLE() that would trigger in this case. Let's be on > the safe side and make sure these always have is_pv_domain() returning > true. > > For the build to still work, this requires a few adjustments elsewhere. > In particular is_pv_64bit_domain() now gains a CONFIG_PV dependency, > which means that is_pv_32bit_domain() || is_pv_64bit_domain() is no > longer guaranteed to be the same as is_pv_domain(). > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > --- > v2: Add comment.
Sorry for not replying earlier, I've been thinking about this because I don't really like this approach as I think it makes code harder to follow for two reasons, first is_pv_32bit_domain() || is_pv_64bit_domain() != is_pv_domain(), which I could live with, and then also is_pv_64bit_domain() returning different values for system domains depending on whether CONFIG_PV is enabled. Given that AFAICT this patch is not fixing any actively identified issue I would rather prefer to introduce is_system_domain and use it when appropriate? I think that would be clearer long term, and avoid tying ourselves deeper into aliasing system domain with PV domains. Thanks, Roger.
