On 06.04.2021 12:36, Luca Fancellu wrote: > Modification to include/public/grant_table.h: > > 1) Change anonymous structure to be named structure, > because doxygen can't deal with them.
Especially in the form presented (adding further name space clutter for consumers to fall over) I object to this, most notably ... > @@ -584,7 +599,7 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_swap_grant_ref_t); > * page granted to the calling domain by a foreign domain. > */ > struct gnttab_cache_flush { > - union { > + union a { ... this one. Jan