On Tue, Mar 30, 2021 at 05:37:02PM +0200, Jan Beulich wrote: > On 23.03.2021 10:58, Roger Pau Monne wrote: > > Such helper is based on the existing functions to fetch a CPUID and > > MSR policies, but uses the xc_cpu_policy_t type to return the data to > > the caller. > > > > No user of the interface introduced on the patch. > > > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > Reviewed-by: Jan Beulich <jbeul...@suse.com> > with again a minor remark (plus of course the same that I made for > patch 4): > > > --- a/tools/include/xenctrl.h > > +++ b/tools/include/xenctrl.h > > @@ -2599,6 +2599,8 @@ void xc_cpu_policy_destroy(xc_cpu_policy_t policy); > > /* Retrieve a system policy, or get/set a domains policy. */ > > int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx, > > xc_cpu_policy_t policy); > > +int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid, > > + xc_cpu_policy_t policy); > > Generally I'd expect domid_t to be used for domain IDs.
Me too, but xenctrl.h seems to consistently use uint32_t for domain ids. I'm fine to use domid_t here, but I assumed there was a reason for using uint32_t uniformly there. Thanks, Roger.
