On 23.03.2021 10:58, Roger Pau Monne wrote: > Also change libxl__cpuid_legacy to propagate the error from > xc_cpuid_apply_policy into callers. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
This looks to do what it means to do and also none of the present callers of the functions modified here ignore the return values, so Reviewed-by: Jan Beulich <jbeul...@suse.com> I wonder however how to ensure similar problems won't get re-introduced down the road. In the hypervisor I'd recommend adding __must_check everywhere, but I have no idea what the tool stack policy is in this regard. Jan