On 22/03/2021 14:52, Jan Beulich wrote: > On 22.03.2021 14:33, Jason Andryuk wrote: >> make install-xen fails when EFI_VENDOR is set (=fedora) with: >> install: cannot create regular file >> '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such >> file or directory >> >> Create the EFI_VENDOR directory so xen.efi can be installed within. >> >> This removes the need for Fedora and Qubes xen.spec files to manually >> create the directory in advance. > While I'm not strictly against, I'd like to point out that it was > deliberate to not create this directory here. I also didn't expect > anyone's xen.spec to do so. Instead I'd expect the distro to create > it during OS installation. If this was a bad assumption, I'd prefer > if the commit message here could point out why such an expectation > won't hold in general.
This reasoning is broken for anything other `make install DESTDIR=/` on a live system. It is incompatible with how RPM, deb, etc packages work. ~Andrew
