On Wed, Mar 03, 2021 at 11:46:44AM +0000, Andrew Cooper wrote:
> On 03/03/2021 08:33, Roger Pau Monne wrote:
> > This requires adding some logic in the build script in order to be
> > able to pass specific Xen Kconfig options.
> >
> > Setting any CONFIG_* environment variable when executing the build
> > script will set such variable in the empty .config file before
> > running the olddefconfig target. The .config file is also checked
> > afterwards to assert the option has not been lost as part of the
> > configuration process.
> >
> > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
> > ---
> > Cc: Jan Beulich <jbeul...@suse.com>
> > ---
> > Not sure whether there's some easiest way to force a config option to
> > a set value from the command line.
> 
> I'm -2 to this.  We've already use thousands of machine minutes per
> push, and this corner case isn't worth adding another 30 minutes or so
> per push.

In fact I think those builds could be hypervisor only, which will
limit them to a couple of minutes?

Would that be an acceptable compromise?

Not just to test NR_CPUS, but in general for testing specific Kconfg
options.

Likely randconfig should also be an hypervisor build only, there's no
reason to do a build test of the tools with a hypervisor randconfig.
Let me prepare a patch for that.

Thanks, Roger.

Reply via email to