Andrew Cooper writes ("Re: [PATCH] tools: Improve signal handling in xen-vmtrace"): > In which case, what other signals potentially need dealing with? Lets > get them all fixed in one go. > > When that's done, we should make it installed by default, to match its > expected usecase.
With my tools maintainer hat on: TERM INT HUP PIPE QUIT Not sure if we can be bothered with SIGTSTP. If you want to be nice, when a signal occurs. arrange to re-raise it after cleanup. After all, exiting with stderr blather and a non-zero exit status, merely for SIGPIPE, is rather unfriendly. This means writing the signal number to the volatile. With my release manager hat on: I do not intend to give a release ack to install this by default, at this stage. It would have been better to have made this program a proper utility from the start, but it has now missed the boat for being a supported feature for 4.15. OTOH given that it is not installed by default, nor supported, I would welcome impreovements to it that I don't think will break the build. Ian.