On 2/26/21 3:53 PM, Julien Grall wrote: > Hi Norbert, > > On 26/02/2021 14:41, Norbert Manthey wrote: >> In case of a failure deep in the call tree, we might return NULL as the >> value of the domain. In that case, error out instead of dereferencing >> the NULL pointer. >> >> This bug was discovered and resolved using Coverity Static Analysis >> Security Testing (SAST) by Synopsys, Inc. > > This commit message is not very descriptive. Internally, I suggested: > > " > tools/xenstore: Harden xs_domain_is_introduced() > > The function single_with_domid() may return NULL if something > went wrong (e.g. XenStored returns an error or the connection is > in bad state). > > They are unlikely but not impossible, so it would be better to > return an error and allow the caller to handle it gracefully rather > than crashing. > > In this case we should treat it as the domain has disappeared (i.e. > return false) as the caller will not likely going to be able to > communicate with XenStored again. > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. > " > > I would have expected this to be addressed given that...
Understood. I will iterate. Norbert > >> >> Signed-off-by: Norbert Manthey <nmant...@amazon.de> >> Reviewed-by: Julien Grall <jgr...@amazon.co.uk > ... you carried over my reviewed-by tag. > > > Cheers, > > -- > Julien Grall Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879
