> From: Jan Beulich <jbeul...@suse.com> > Sent: Thursday, February 25, 2021 4:44 PM > > On 22.02.2021 11:56, Jan Beulich wrote: > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -428,6 +428,14 @@ static void vmx_domain_relinquish_resour > > vmx_free_vlapic_mapping(d); > > } > > > > +static void domain_creation_finished(struct domain *d) > > +{ > > + if ( has_vlapic(d) && !mfn_eq(d->arch.hvm.vmx.apic_access_mfn, > _mfn(0)) && > > + set_mmio_p2m_entry(d, gaddr_to_gfn(APIC_DEFAULT_PHYS_BASE), > > + d->arch.hvm.vmx.apic_access_mfn, > > PAGE_ORDER_4K) ) > > + domain_crash(d); > > +} > > Having noticed that in patch 2 I also need to arrange for > ept_get_entry_emt() to continue to return WB for this page, I'm > inclined to add a respective assertion here. Would anyone object > to me doing so? > > Kevin, Jun - I'd like this to also serve as a ping for an ack > (with or without the suggested ASSERT() addition). >
Reviewed-by: Kevin Tian <kevin.t...@intel.com>