On 17/02/2021 10:46, Jan Beulich wrote: > Prior to its introduction, v1 entries weren't checked for this flag, and > the flag also has been meaningless for v1 entries. Therefore it also > shouldn't be checked. (The only consistent alternative would be to also > check for all currently undefined flags to be clear.)
We recently had a similar discussion for the stable libs. Whatever we do, an unexpected corner case needs to break. Checking for all undefined flags up front is far cleaner - absolutely nothing good can come for a guest which set GTF_sub_page with v1, and is expecting it to work, and this way, we do all breaking in one go, rather than breaking $N times in the future as new flags get added. ~Andrew
