On Mon, 15 Feb 2021, Jan Beulich wrote:
> On 13.02.2021 14:50, Marek Marczykowski-Górecki wrote:
> > On Fri, Feb 12, 2021 at 06:05:40PM -0800, Stefano Stabellini wrote:
> >> If rombios, seabios and ovmf are all disabled, don't attempt to build
> >> hvmloader.
> >
> > What if you choose to not build any of rombios, seabios, ovmf, but use
> > system one instead? Wouldn't that exclude hvmloader too?
>
> Even further - one can disable all firmware and have every guest
> config explicitly specify the firmware to use, afaict.
I didn't realize there was a valid reason for wanting to build hvmloader
without rombios, seabios, and ovfm.
> > This heuristic seems like a bit too much, maybe instead add an explicit
> > option to skip hvmloader?
>
> +1 (If making this configurable is needed at all - is having
> hvmloader without needing it really a problem?)
The hvmloader build fails on Alpine Linux x86:
https://gitlab.com/xen-project/xen/-/jobs/1033722465
I admit I was just trying to find the fastest way to make those Alpine
Linux builds succeed to unblock patchew: although the Alpine Linux
builds are marked as "allow_failure: true" in gitlab-ci, patchew will
still report the whole battery of tests as "failure". As a consequence
the notification emails from patchew after a build of a contributed
patch series always says "job failed" today, making it kind of useless.
See attached.
I would love if somebody else took over this fix as I am doing this
after hours, but if you have a simple suggestion on how to fix the
Alpine Linux hvmloader builds, or skip the build when appropriate, I can
try to follow up.
Otherwise for now it might be best to just temporarily remove the Alpine
Linux x86 builds from gitlab-ci.
Any thoughts?
From: no-re...@patchew.org
To: famzh...@amazon.com
Cc: sstabell...@kernel.org,, car...@cardoe.com,, w...@xen.org,,
bertrand.marq...@arm.com,, jul...@xen.org,, andrew.coop...@citrix.com
Date: Thu, 11 Feb 2021 05:03:50 -0800 (PST)
Hi,
Patchew automatically ran gitlab-ci pipeline with this patch (series) applied,
but the job failed. Maybe there's a bug in the patches?
You can find the link to the pipeline near the end of the report below:
Type: series
Message-id: 20210210092211.53359-1-roger....@citrix.com
Subject: [PATCH] x86/irq: simplify loop in unmap_domain_pirq
=== TEST SCRIPT BEGIN ===
#!/bin/bash
sleep 10
patchew gitlab-pipeline-check -p xen-project/patchew/xen
=== TEST SCRIPT END ===
warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/
warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/
From https://gitlab.com/xen-project/patchew/xen
* [new tag] patchew/20210210092211.53359-1-roger....@citrix.com
-> patchew/20210210092211.53359-1-roger....@citrix.com
Switched to a new branch 'test'
58b36b77d5 x86/irq: simplify loop in unmap_domain_pirq
=== OUTPUT BEGIN ===
[2021-02-11 11:10:07] Looking up pipeline...
[2021-02-11 11:10:07] Found pipeline 254760433:
https://gitlab.com/xen-project/patchew/xen/-/pipelines/254760433
[2021-02-11 11:10:07] Waiting for pipeline to finish...
[2021-02-11 11:25:12] Still waiting...
[2021-02-11 11:40:17] Still waiting...
[2021-02-11 11:55:21] Still waiting...
[2021-02-11 12:10:29] Still waiting...
[2021-02-11 12:25:35] Still waiting...
[2021-02-11 12:40:40] Still waiting...
[2021-02-11 12:55:45] Still waiting...
[2021-02-11 13:03:48] Pipeline failed
[2021-02-11 13:03:48] Job 'alpine-3.12-gcc-debug-arm64' in stage 'build' is
failed
[2021-02-11 13:03:48] Job 'alpine-3.12-gcc-arm64' in stage 'build' is failed
[2021-02-11 13:03:48] Job 'qemu-smoke-x86-64-clang-pvh' in stage 'test' is
skipped
[2021-02-11 13:03:48] Job 'qemu-smoke-x86-64-gcc-pvh' in stage 'test' is skipped
[2021-02-11 13:03:48] Job 'qemu-smoke-x86-64-clang' in stage 'test' is skipped
[2021-02-11 13:03:48] Job 'qemu-smoke-x86-64-gcc' in stage 'test' is skipped
[2021-02-11 13:03:48] Job 'qemu-smoke-arm64-gcc' in stage 'test' is skipped
[2021-02-11 13:03:48] Job 'qemu-alpine-arm64-gcc' in stage 'test' is skipped
[2021-02-11 13:03:48] Job 'build-each-commit-gcc' in stage 'test' is skipped
[2021-02-11 13:03:48] Job 'alpine-3.12-clang-debug' in stage 'build' is failed
[2021-02-11 13:03:48] Job 'alpine-3.12-clang' in stage 'build' is failed
[2021-02-11 13:03:48] Job 'alpine-3.12-gcc-debug' in stage 'build' is failed
[2021-02-11 13:03:48] Job 'alpine-3.12-gcc' in stage 'build' is failed
=== OUTPUT END ===
Test command exited with code: 1
