On 04/02/2021 16:50, Oleksandr wrote:
>
> On 04.02.21 17:58, Andrew Cooper wrote:
>
> Hi Andrew
>
>> It is not permitted to edit the VERS clause for a version in a
>> release of Xen.
>>
>> Revert xendevicemodel_set_irq_level()'s inclusion in .so.1.2 and bump
>> the the
>> library minor version to .so.1.4 instead.
>>
>> Fixes: 5d752df85f ("xen/dm: Introduce xendevicemodel_set_irq_level DM
>> op")
>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
>> ---
>> CC: Ian Jackson <i...@xenproject.org>
>> CC: Wei Liu <w...@xen.org>
>> CC: Julien Grall <julien.gr...@arm.com>
>> CC: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com>
>> CC: Stefano Stabellini <sstabell...@kernel.org>
>> CC: Wei Chen <wei.c...@arm.com>
>>
>> Critical to include in 4.15, as this is an ABI breakage.
> I am sorry for the breakage, I admit I didn't know that
> "It is not permitted to edit the VERS clause for a version in a
> release of Xen."To be honest, its not Xen specific. Its any shared object with a stable API/ABI. It is explicitly fine to bump the minor version to add new things, but you must never change the ABI of one which has been released. ~Andrew
