Andrew Cooper writes ("[PATCH for-4.15 1/2] libs/foreignmem: Drop useless
and/or misleading logging"):
> These log lines are all in response to single system calls, and do not provide
> any information which the immediate caller can't determine themselves. It is
> however exceedinly rude to put junk like this onto stderr, especially as
> system call failures are not even error conditions in certain circumstances.
>
> The FreeBSD logging has stale function names in, and solaris shouldn't have
> passed code review to start with.
>
> No functional change.
Thanks.
Reviewed-by: Ian Jackson <i...@xenproject.org>
Release-Acked-by: Ian Jackson <i...@xenproject.org>
> int saved_errno = errno;
> - PERROR("XXXXXXXX");
> +
That's particularly wtf...
Ian.
