Andrew Cooper writes ("Re: [PATCH] x86/build: correctly record dependencies of asm-offsets.s"): > On 01/02/2021 14:56, Jan Beulich wrote: > > Going through an intermediate *.new file requires telling the compiler > > what the real target is, so that the inclusion of the resulting .*.d > > file will actually be useful. > > > > Fixes: 7d2d7a43d014 ("x86/build: limit rebuilding of asm-offsets.h") > > Reported-by: Julien Grall <jul...@xen.org> > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Acked-by: Andrew Cooper <andrew.coop...@citrix.com>, whatever the > outcome of the discussion below.
This is a bugfix and does not need a release ack, but FTAOD Release-Acked-by: Ian Jackson <i...@xenproject.org> > > Already on the original patch I did suggest that perhaps Arm would want > > to follow suit. So again - perhaps the rules should be unified by moving > > to common code? Quite so. Ian.