On 26/01/2021 22:47, Manuel Bouyer wrote: > Use unsigned char variable, or cast to (unsigned char), for > tolower()/islower() and friends. Fix compiler error > array subscript has type 'char' [-Werror=char-subscripts] > > Signed-off-by: Manuel Bouyer <bou...@netbsd.org> > Reviewed-by: Ian Jackson <ian.jack...@eu.citrix.com> > Release-Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> > --- > tools/libs/light/libxl_qmp.c | 2 +- > tools/xentrace/xentrace.c | 2 +- > xen/tools/symbols.c | 4 ++--
Acked-by: Andrew Cooper <andrew.coop...@citrix.com> This is totally ugly, but it is a well known totally ugly corner case of C. Non-freestanding bits have to play by C's rules to be compatible. ~Andrew