Jan Beulich writes ("[PATCH] xenstored: fix build on libc without O_CLOEXEC"):
> The call to lu_read_state() would remain unresolved in this case. Frame
> the construct by a suitable #ifdef, and while at it also frame command
> line handling related pieces similarly.
>
> Fixes: 9777fa6b6ea0 ("tools/xenstore: evaluate the live update flag when
> starting")
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
Reviewed-by: Ian Jackson <ian.jack...@eu.citrix.com>
Personally my preference would have been to retain the command line
option parsing and have it bomb out with an error message here:
> +#ifndef NO_LIVE_UPDATE
> /* Read state in case of live update. */
> if (live_update)
> lu_read_state();
> +#endif
But you have written the patch and what you have done is reasonable.
Thanks,
Ian.
