On 26.01.2021 12:06, Roger Pau Monne wrote: > There are two duplicated calls to cleanup_domain_irq_pirq in > unmap_domain_pirq. > > The first one in the for loop will be called with exactly the same > arguments as the call placed closer to the loop start.
I'm having trouble figuring out which two instances you refer to: To me "first one" and "closer to the start" are two ways of expressing the same thing. You don't refer to the call to clear_domain_irq_pirq(), do you, when the two calls you remove are to cleanup_domain_irq_pirq()? Admittedly quite similar names, but entirely different functions. > The logic used in the loop seems extremely complex to follow IMO, > there are several breaks for exiting the loop, and the index (i) is > also updated in different places. Indeed, and it didn't feel well already back at the time when I much extended this to support multi-vector MSI. I simply didn't have any good idea how to streamline all of this (short of rewriting it altogether, which would have made patch review quite difficult). If you have thoughts, I'm all ears. Jan
