> -----Original Message----- > From: Oleksandr Tyshchenko <olekst...@gmail.com> > Sent: 25 January 2021 19:08 > To: xen-devel@lists.xenproject.org > Cc: Julien Grall <julien.gr...@arm.com>; Jan Beulich <jbeul...@suse.com>; > Andrew Cooper > <andrew.coop...@citrix.com>; Roger Pau Monné <roger....@citrix.com>; Wei Liu > <w...@xen.org>; George > Dunlap <george.dun...@citrix.com>; Ian Jackson <i...@xenproject.org>; Julien > Grall <jul...@xen.org>; > Stefano Stabellini <sstabell...@kernel.org>; Paul Durrant <p...@xen.org>; > Daniel De Graaf > <dgde...@tycho.nsa.gov>; Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > Subject: [PATCH V5 09/22] xen/ioreq: Make x86's IOREQ related dm-op handling > common > > From: Julien Grall <julien.gr...@arm.com> > > As a lot of x86 code can be re-used on Arm later on, this patch > moves the IOREQ related dm-op handling to the common code. > > The idea is to have the top level dm-op handling arch-specific > and call into ioreq_server_dm_op() for otherwise unhandled ops. > Pros: > - More natural than doing it other way around (top level dm-op > handling common). > - Leave compat_dm_op() in x86 code. > Cons: > - Code duplication. Both arches have to duplicate dm_op(), etc. > > Make the corresponding functions static and rename them according > to the new naming scheme (including dropping the "hvm" prefixes). > > Introduce common dm.c file as a resting place for the do_dm_op() > (which is identical for both Arm and x86) to minimize code duplication. > The common DM feature is supposed to be built with IOREQ_SERVER > option enabled (as well as the IOREQ feature), which is selected > for x86's config HVM for now. > > Also update XSM code a bit to let dm-op be used on Arm. > > This support is going to be used on Arm to be able run device > emulator outside of Xen hypervisor. > > Signed-off-by: Julien Grall <julien.gr...@arm.com> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > Acked-by: Jan Beulich <jbeul...@suse.com> > [On Arm only] > Tested-by: Wei Chen <wei.c...@arm.com> >
Reviewed-by: Paul Durrant <p...@xen.org>
