On 08/10/2020 19:57, Paul Durrant wrote:
> diff --git a/xen/include/public/save.h b/xen/include/public/save.h
> new file mode 100644
> index 0000000000..c4be9f570c
> --- /dev/null
> +++ b/xen/include/public/save.h
> @@ -0,0 +1,66 @@
> +/*
> + * save.h
> + *
> + * Structure definitions for common PV/HVM domain state that is held by Xen.
What exactly is, and is not in scope, for this new stream? The PV above
I think refers to "paravirtual state", not PV guests.
> +#define _DOMAIN_CONTEXT_RECORD_ALIGN 3
> +#define DOMAIN_CONTEXT_RECORD_ALIGN (1U << _DOMAIN_CONTEXT_RECORD_ALIGN)
Do we need the logarithm version?
> +
> +enum {
> + DOMAIN_CONTEXT_END,
> + DOMAIN_CONTEXT_START,
> + /* New types go here */
> + DOMAIN_CONTEXT_NR_TYPES
> +};
Does this enum ever end up in an API?
We might be ok as we're inside __XEN_TOOLS__, but enums normally cannot
be used in ABI's because their size is implementation defined, and not
always 4 bytes.
~Andrew
