At 12:07 +0100 on 25 Jan (1611576438), Jan Beulich wrote: > 15 apparently once used to be the last valid type to request a callback > for, and the dimension of the respective array. The arrays meanwhile are > larger than this (in a benign way, i.e. no caller ever sets a mask bit > higher than 15), dimensioned by SH_type_unused. Have the ASSERT()s > follow suit and add build time checks at the call sites. > > Also adjust a comment naming the wrong of the two functions. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
Reviewed-by: Tim Deegan <t...@xen.org> > --- > The ASSERT()s being adjusted look redundant with the BUILD_BUG_ON()s > being added, so I wonder whether dropping them wouldn't be the better > route. I'm happy to keep both, as they do slightly different things. Thanks for fixing this up! Tim.
