On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote:
> From: Manuel Bouyer <bou...@netbsd.org>
>
> Pass bridge name to qemu as command line option
> When starting qemu, set an environnement variable XEN_DOMAIN_ID,
> to be used by qemu helper scripts
>
> Signed-off-by: Manuel Bouyer <bou...@netbsd.org>
> ---
> tools/libs/light/libxl_dm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
> index 3da83259c0..8866c3f5ad 100644
> --- a/tools/libs/light/libxl_dm.c
> +++ b/tools/libs/light/libxl_dm.c
> @@ -761,6 +761,8 @@ static int libxl__build_device_model_args_old(libxl__gc
> *gc,
> int nr_set_cpus = 0;
> char *s;
>
> + flexarray_append_pair(dm_envs, "XEN_DOMAIN_ID", GCSPRINTF("%d",
> domid));
> +
> if (b_info->kernel) {
> LOGD(ERROR, domid, "HVM direct kernel boot is not supported by "
> "qemu-xen-traditional");
> @@ -1547,8 +1549,10 @@ static int
> libxl__build_device_model_args_new(libxl__gc *gc,
> flexarray_append(dm_args, "-netdev");
> flexarray_append(dm_args,
> GCSPRINTF("type=tap,id=net%d,ifname=%s,"
> + "br=%s,"
> "script=%s,downscript=%s",
> nics[i].devid, ifname,
> + nics[i].bridge,
You have some hard tabs in there.
Also looking at the manual the br= option seems to only be available
for the bridge networking mode, while here Xen is using tap instead?
Thanks, Roger.
