On Tue, 24 Nov 2020, Stefano Stabellini wrote: > Allow failure for these jobs. Currently they fail because hvmloader > doesn't build with musl. The failures don't block the pipeline. > > Signed-off-by: Stefano Stabellini <stefano.stabell...@xilinx.com> > --- > This patch is probably required: > https://github.com/alpinelinux/aports/blob/master/main/xen/musl-hvmloader-fix-stdint.patch
We could simply disable the hvmloader build when it is not necessary. When OVMF, SeaBios, and Rombios are all disabled, it doesn't make sense to build hvmloader. If this assumption is correct, then the patch below fixes the Alpine Linux build (as long as we pass --disable-seabios and --disable-rombios appropriately) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index 48bd9ab731..a6aada576f 100644 --- a/config/Tools.mk.in +++ b/config/Tools.mk.in @@ -55,6 +55,15 @@ CONFIG_QEMU_XEN := @qemu_xen@ CONFIG_QEMUU_EXTRA_ARGS:= @EXTRA_QEMUU_CONFIGURE_ARGS@ CONFIG_LIBNL := @libnl@ CONFIG_GOLANG := @golang@ +ifeq ($(CONFIG_ROMBIOS),y) +CONFIG_FIRMWARE=y +endif +ifeq ($(CONFIG_SEABIOS),y) +CONFIG_FIRMWARE=y +endif +ifeq ($(CONFIG_OVMF),y) +CONFIG_FIRMWARE=y +endif CONFIG_SYSTEMD := @systemd@ SYSTEMD_CFLAGS := @SYSTEMD_CFLAGS@ diff --git a/tools/Makefile b/tools/Makefile index ed71474421..9821a7f5d5 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -14,7 +14,7 @@ SUBDIRS-y += examples SUBDIRS-y += hotplug SUBDIRS-y += xentrace SUBDIRS-$(CONFIG_XCUTILS) += xcutils -SUBDIRS-$(CONFIG_X86) += firmware +SUBDIRS-$(CONFIG_FIRMWARE) += firmware SUBDIRS-y += console SUBDIRS-y += xenmon SUBDIRS-y += xentop
