Hi Andrew,

> On 25 Nov 2020, at 14:49, Andrew Cooper <andrew.coop...@citrix.com> wrote:
> 
> The internal package config file for libxenlight reads (reformatted to avoid
> exceeding the SMTP 998-character line length):
> 
>  Libs: -L${libdir}
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/gnttab
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/foreignmemory
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/devicemodel
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/ctrl
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/store
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/hypfs
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/gnttab
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/foreignmemory
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/devicemodel
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/ctrl
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/guest
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/light
>  -lxenlight
> 
> Drop duplicate -rpath-link='s to turn it into the slightly-more-manageable:
> 
>  Libs: -L${libdir}
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/ctrl
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/devicemodel
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/foreignmemory
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/gnttab
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/guest
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/hypfs
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/light
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/store
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore
>  
> -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog
>  -lxenlight
> 
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com>

Nice reduction of the output :-)

Cheers
Bertrand

> ---
> CC: Ian Jackson <i...@xenproject.org>
> CC: Wei Liu <w...@xen.org>
> CC: Juergen Gross <jgr...@suse.com>
> ---
> tools/Rules.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/Rules.mk b/tools/Rules.mk
> index f61da81f4a..5d92ff0699 100644
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -184,7 +184,7 @@ $(PKG_CONFIG_DIR)/%.pc: Makefile 
> $(XEN_ROOT)/tools/Rules.mk $(PKG_CONFIG_DIR)
>       echo "Description: $(PKG_CONFIG_DESC)"; \
>       echo "Version: $(PKG_CONFIG_VERSION)"; \
>       echo "Cflags: -I\$${includedir} $(CFLAGS_xeninclude)"; \
> -     echo "Libs: -L\$${libdir} $(PKG_CONFIG_USELIBS) -l$(PKG_CONFIG_LIB)"; \
> +     echo "Libs: -L\$${libdir} $(sort $(PKG_CONFIG_USELIBS)) 
> -l$(PKG_CONFIG_LIB)"; \
>       echo "Libs.private: $(PKG_CONFIG_LIBSPRIV)"; \
>       echo "Requires.private: $(PKG_CONFIG_REQPRIV)"; \
>       } > $@
> -- 
> 2.11.0
> 
> 


Reply via email to