Hi,
On 13/11/2020 05:18, Jürgen Groß wrote:
On 12.11.20 22:38, Stefano Stabellini wrote:
On Thu, 12 Nov 2020, Jan Beulich wrote:
On 12.11.2020 13:50, Jürgen Groß wrote:
Any further comments, or even better, Acks?
To be honest I'd prefer to have at least one of the people Cc-ed
minimally indicate they consider this a good idea. No need for a
close review or such, just a basic opinion. Anyone?
I see Jan's point that it is not clear how much this is going to help in
production. However, it is not going to hurt either, and I have been
told a few times recently that debugging Xen is not easy. Anything that
helps in that regard would be good. So I think this patch would be an
improvement.
This patch is an effort to get better diagnostic data in case of
Xen crashes from our largest customer, so clearly intended for
production use.
I agree with this statement. When you get a crash from Xen in
production, it can be useful to get as much information as possible
dumped. Some of the information printed by the debugkeys cannot be
retrieved from a crashkernel.
Cheers,
--
Julien Grall
