> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 12 November 2020 11:45 > To: Oleksandr Tyshchenko <olekst...@gmail.com>; Paul Durrant <p...@xen.org> > Cc: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com>; Andrew Cooper > <andrew.coop...@citrix.com>; > Roger Pau Monné <roger....@citrix.com>; Wei Liu <w...@xen.org>; George Dunlap > <george.dun...@citrix.com>; Ian Jackson <i...@xenproject.org>; Julien Grall > <jul...@xen.org>; Stefano > Stabellini <sstabell...@kernel.org>; Jun Nakajima <jun.nakaj...@intel.com>; > Kevin Tian > <kevin.t...@intel.com>; Julien Grall <julien.gr...@arm.com>; > xen-devel@lists.xenproject.org > Subject: Re: [PATCH V2 12/23] xen/ioreq: Remove "hvm" prefixes from involved > function names > > On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: > > From: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > > > > This patch removes "hvm" prefixes and infixes from IOREQ > > related function names in the common code. > > AT least some of the functions touched here would be nice to be > moved to a more consistent new naming scheme right away, to > avoid having to touch all the same places again. I guess ioreq > server functions would be nice to all start with ioreq_server_ > and ioreq functions to all start with ioreq_. E.g. ioreq_send() > and ioreq_server_select(). > > Paul, thoughts? >
Yes, that sounds like a good idea. Obviously the code has grown a little organically so some naming cleanup is welcome. Paul > Jan
