On 11.11.2020 21:07, Paul Durrant wrote: > --- a/xen/include/asm-x86/hvm/viridian.h > +++ b/xen/include/asm-x86/hvm/viridian.h > @@ -59,6 +59,14 @@ struct viridian_domain > { > union hv_guest_os_id guest_os_id; > union hv_vp_assist_page_msr hypercall_gpa; > + unsigned long hypercall_flags; > + > +#define _HCALL_spin_wait 0 > +#define _HCALL_flush 1 > +#define _HCALL_flush_ex 2 > +#define _HCALL_ipi 3 > +#define _HCALL_ipi_ex 4
I'd like to suggest for this to either be unsigned int until more than 32 bits are needed, or be using DECLARE_BITMAP() right away. Jan