Le 11/3/20 à 10:15 AM, Jan Beulich a écrit :
On 31.10.2020 16:14, Frédéric Pierret (fepitre) wrote:--- a/xen/Makefile +++ b/xen/Makefile @@ -6,6 +6,8 @@ export XEN_EXTRAVERSION ?= -unstable$(XEN_VENDORVERSION) export XEN_FULLVERSION = $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION) -include xen-version+export SOURCE_DATE_EPOCH ?= $(shell git log -1 --format=%ct 2>/dev/null)In patch 1 you also use the variable under tools/. Why do you place this here rather than in the top level Makefile? This said I'm not convinced anyway that we want this to be the default. I'd rather see this as something to get set by the package build process of distros, outside of any of the source files. Jan
In fact this was intended to provide a default/example value. Indeed, each package manager should handle this with changelog or such. This is not mandatory and if not wanted by default, maybe add this example value into the INSTALL documentation? Frédéric
OpenPGP_0x484010B5CDC576E2.asc
Description: application/pgp-keys
OpenPGP_signature
Description: OpenPGP digital signature
