On 05.10.2020 11:49, Paul Durrant wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -174,15 +174,6 @@ int iommu_domain_init(struct domain *d, unsigned int > opts) > hd->node = NUMA_NO_NODE; > #endif > > - ret = arch_iommu_domain_init(d); > - if ( ret ) > - return ret; > - > - hd->platform_ops = iommu_get_ops(); > - ret = hd->platform_ops->init(d); > - if ( ret || is_system_domain(d) ) > - return ret;
Are you suggesting the is_system_domain() here has become unnecessary? If so, it would be nice if you could say when or why. Otherwise I would assume it's needed to avoid setting one or both of the fields. Jan
