On 28.10.2020 00:32, Stefano Stabellini wrote: > On Mon, 26 Oct 2020, Rahul Singh wrote: >> --- a/xen/drivers/char/Kconfig >> +++ b/xen/drivers/char/Kconfig >> @@ -4,6 +4,13 @@ config HAS_NS16550 >> help >> This selects the 16550-series UART support. For most systems, say Y. >> >> +config HAS_NS16550_PCI >> + bool "NS16550 UART PCI support" if X86 >> + default y >> + depends on X86 && HAS_NS16550 && HAS_PCI >> + help >> + This selects the 16550-series UART PCI support. For most systems, say >> Y. > > I think that this should be a silent option: > if HAS_NS16550 && HAS_PCI && X86 -> automatically enable > otherwise -> automatically disable > > No need to show it to the user.
I agree in principle, but I don't see why an X86 dependency gets added here. HAS_PCI really should be all that's needed. Jan
